Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded flatpak to org.freedesktop.Platform version 23.08 #3968

Merged

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Sep 19, 2023

What does this PR do?

feat: upgraded flatpak to org.freedesktop.Platform version 23.08

What issues does this PR fix or reference?

fixes #3966

How to test this PR?

  1. Build the flatpak package:

    MODE=production npm run build && ./node_modules/.bin/electron-builder build --config .electron-builder.config.cjs --linux flatpak
    
  2. Install the flatpak package:

    flatpak install -u dist/podman-desktop-1.5.0-next.flatpak 
    

@themr0c themr0c requested review from benoitf and a team as code owners September 19, 2023 13:13
@themr0c themr0c requested review from dgolovin and jeffmaury and removed request for a team September 19, 2023 13:13
@themr0c
Copy link
Contributor Author

themr0c commented Sep 19, 2023

Tested successfully on Fedora 38.

@benoitf
Copy link
Collaborator

benoitf commented Sep 19, 2023

@themr0c
Copy link
Contributor Author

themr0c commented Sep 19, 2023

@benoitf
Copy link
Collaborator

benoitf commented Sep 19, 2023

I think it requires flathub/org.electronjs.Electron2.BaseApp#43 first

@themr0c themr0c marked this pull request as draft September 19, 2023 15:09
@themr0c
Copy link
Contributor Author

themr0c commented Sep 19, 2023

You are entirely right @benoitf. Converted to draft, as long as BaseApp 23.08 is not out.

@mairin
Copy link
Member

mairin commented Sep 19, 2023

@themr0c just tested - seems fine! in GNOME it shows up under Development in the menu but not under Utilities.

@themr0c
Copy link
Contributor Author

themr0c commented Sep 27, 2023

flathub/org.electronjs.Electron2.BaseApp#43 has been done.

@benoitf
Copy link
Collaborator

benoitf commented Sep 27, 2023

FYI you had a comment there flathub/io.podman_desktop.PodmanDesktop#31 (comment)

@themr0c themr0c marked this pull request as ready for review September 27, 2023 12:13
@themr0c
Copy link
Contributor Author

themr0c commented Sep 27, 2023

23.08 baseapp is out now.

Can you check if desktop notifications work without --talk-name=org.freedesktop.Notifications?

The 23.08 baseapp includes libnotify 0.8.2 which should not require that hole.

quoting flathub/io.podman_desktop.PodmanDesktop#31 (comment)

@themr0c
Copy link
Contributor Author

themr0c commented Sep 27, 2023

@benoitf flathub/io.podman_desktop.PodmanDesktop#31 is rebuilding. I am not sure how the merges should be synchronized (which one first? both simultaneously?)

@benoitf
Copy link
Collaborator

benoitf commented Sep 27, 2023

@themr0c I think here it's better b/c it's not rolled out to all people using flatpak

on flathub, once merged all people get it in 3-4hours

so better to check manual .flatpak here for a while before merging on flathub

WDYT ?

@benoitf
Copy link
Collaborator

benoitf commented Nov 15, 2023

flathub/io.podman_desktop.PodmanDesktop#31 has been merged, merging there

@benoitf benoitf force-pushed the issue-3966-upgrade-flatpak-platform branch from 3238b90 to bc060b8 Compare November 15, 2023 09:49
 containers#3966

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@benoitf benoitf force-pushed the issue-3966-upgrade-flatpak-platform branch from bc060b8 to a86e237 Compare November 15, 2023 10:24
@benoitf benoitf enabled auto-merge (squash) November 15, 2023 10:24
@benoitf benoitf merged commit cd447a2 into containers:main Nov 15, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade flatpak to org.freedesktop.Platform version 23.08
4 participants