fix: make min-height=0px for tabs on container details page #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix containers#3992. Signed-off-by: Denis Golovin <dgolovin@redhat.com>
dgolovin
requested review from
jeffmaury and
cdrage
and removed request for
a team
dgolovin
changed the title
benoitf
reviewed
Sep 21, 2023
benoitf
approved these changes
Sep 21, 2023
deboer-tim
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Tested. +1 conditional on making the change @benoitf suggested.
To be consistent with other pages like FormPage we should add "flex w-full overflow-auto" too and make sure all the *Details pages are consistent, but that actually causes more problems with the terminal so I'm not suggesting it for now. Seems like there is some odd behaviour with the terminal, but maybe I just need #3955 too.
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #3992.
Screenshot/screencast of this PR
Screen.Recording.2023-09-20.at.9.11.23.PM.mov
What issues does this PR fix or reference?
Fix #3992.
How to test this PR?
See #3992 screen recording to replicate.