feat: add the setting to start a podman machine after its creation #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
reviewed
Sep 22, 2023
benoitf
approved these changes
Sep 22, 2023
|
cc @mairin should we have basic/advanced (hidden by default) options in creation form ? |
|
@lstocchi my feedback is not preventing the merge but probably you need to add a component test ? |
Yes I agree with this or you need to scroll to view/select all options, then you need to re-scroll upwards to see the logs and it's annoying. I'll merge this PR but i'll open an issue if i don't find an existing one that target it. |
-> #3523 |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
force-pushed
the
startMachineOnboaridng
branch
from
185d976
to
5285034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows to set the
--nowflag when executing the create podman machine command.The code was already implemented, the missing thing was the entry in the package.json.
This way when going through the workflow the user will create/start a podman machine or he can decide to disable the start now and just create a machine.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A
How to test this PR?