feat(extension): allow to run admin tasks from extensions #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed several extensions have some code to run admin tasks using like sudo-prompt, or pkexec here it brings a new parameter isAdmin in the exec API so extensions can run admin tasks it uses for macOS osascript allowing to use touch ID pre-req of containers#2998 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed several extensions have some code to run admin tasks using like sudo-prompt, or pkexec
here it brings a new parameter isAdmin in the exec API so extensions can run admin tasks
it uses for macOS osascript allowing to use touch ID
Screenshot/screencast of this PR
What issues does this PR fix or reference?
pre-req for #2998
How to test this PR?
there are some unit tests but the clients of this API are in
#4050