feat: show status text during state changes #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
deboer-tim
force-pushed
the
state-change
branch
2 times, most recently
from
c68885a
to
18ff2a0
Compare
benoitf
approved these changes
Sep 25, 2023
auto-merge was automatically disabled
September 25, 2023 15:24
Rebase failed
deboer-tim
added a commit
that referenced
this pull request
Sep 25, 2023
Currently there is no indication in the status icon when something is being deleted. We're adding text to the age column (#4056), but the design preference is that this is re-enforced by the status icon changing into a spinner. This adds the DELETING status, using a correctly sized Spinner component with no border. Added a test, and some missing tests for other states. Signed-off-by: Tim deBoer <git@tdeboer.ca>
When an object is being deleted there is no indication in the UI. Mairin suggested two changes: - Change status icon to a spinner. (This will be done separately, and although it shows _something_ is happening, it doesn't tell you what it is) - Replacing the age column in the Container/PodList to show Starting/Stopping/ Deleting when one of these state changes is happening, and adding the equivalent message below the action buttons in the corresponding Details page. Since the same state message will appear in all 4 places, I created a really simple StateChange component. It just shows a simple message when in these states, and if you want to hide something when these messages are shown you can use its slot. Fixes #3529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
force-pushed
the
state-change
branch
from
56c17b8
to
b5f4679
Compare
|
'unresolvable' git conflict in GitHub UI, so rebased locally and force pushed. |
deboer-tim
added a commit
that referenced
this pull request
Sep 25, 2023
Currently there is no indication in the status icon when something is being deleted. We're adding text to the age column (#4056), but the design preference is that this is re-enforced by the status icon changing into a spinner. This adds the DELETING status, using a correctly sized Spinner component with no border. Added a test, and some missing tests for other states. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an object is being deleted there is no indication in the UI. Mairin suggested two changes:
Since the same state message will appear in all 4 places, I created a really simple StateChange component. It just shows a simple message when in these states, and if you want to hide something when these messages are shown you can use its slot.
Screenshot/screencast of this PR
Screen.Recording.2023-09-22.at.2.28.43.PM.mov
Screen.Recording.2023-09-22.at.2.29.58.PM.mov
What issues does this PR fix or reference?
Fixes #3529.
How to test this PR?
Use a container or pod that will take a while to start or stop (e.g. Kind container, or deleting a pod on Kube), and watch the age column (or right side of Details).