fix: run image error spacing #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error message over top of the field and label as shown in issue #3628. You can notice the Entrypoint field in the issue is also very close to the following Command label - both fields did not have the pt-4 padding that every other field in this form has. Adding this back leaves a blank line for the error, so I added an if statement as we do in many other uses of ErrorMessage. Fixes #3628. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
cdrage
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes error message over top of the field and label as shown in issue #3628. You can notice the Entrypoint field in the issue is also very close to the following Command label - both fields did not have the pt-4 padding that every other field in this form has. Adding this back leaves a blank line for the error, so I added an if statement as we do in many other uses of ErrorMessage.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #3628.
How to test this PR?
Run an image and type a container name that's already in use.