fix: avoid errors with unexpected JSON input #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
reviewed
Sep 26, 2023
If either Names or Labels of a container was undefined (null),
then there would just be a black screen and an error log...
The docker client library converts any such null values into
empty string (""), so that is what is being used in the test.
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
container-utils-compat
branch
from
5f305ab
to
a656f58
Compare
benoitf
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If either Names or Labels of a container was empty (null), then there would just be a black screen and an error log.
What does this PR do?
Ran into some docker compatibility errors / parsing assumptions, when dealing with showing
containerdcontainers.Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?