Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions-api): add container engine methods #4172

Merged
merged 1 commit into from Oct 3, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 2, 2023

What does this PR do?

Include listImages, createContainer, createNetwork and listNetworks for extension API

depends on

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes #4169

How to test this PR?

@benoitf benoitf requested a review from a team as a code owner October 2, 2023 13:13
@benoitf benoitf requested review from dgolovin and cdrage and removed request for a team October 2, 2023 13:13
listImages, createContainer, createNetwork and listNetworks

fixes containers#4169
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Collaborator Author

benoitf commented Oct 3, 2023

I've rebased

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to access the calls from an extension (I used compose for example).

Specifically tested listNetworks() and createNetwork(.

LGTM!

@cdrage cdrage merged commit 745121e into containers:main Oct 3, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.5.0 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extension-api: should be able to list image, networks, create containers and create networks
3 participants