Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): adds spinning if icon contains ~spin suffix #4188

Merged
merged 1 commit into from Oct 3, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 3, 2023

What does this PR do?

adds spinning animation on ~spin icons

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes #4186

How to test this PR?

unit test provided

@benoitf benoitf requested a review from a team as a code owner October 3, 2023 11:09
@benoitf benoitf requested review from dgolovin and lstocchi and removed request for a team October 3, 2023 11:09
fixes containers#4186
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 450d5eb into containers:main Oct 3, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.5.0 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icons of statusbar could be spinning
3 participants