Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document property setting in EXTENSIONS.md #4221

Merged
merged 2 commits into from Oct 5, 2023

Conversation

shelar1423
Copy link
Contributor

@shelar1423 shelar1423 commented Oct 5, 2023

What does this PR do?

Document feature around property setting

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #3846

How to test this PR?

Signed-off-by: Digvijay Shelar <82649533+shelar1423@users.noreply.github.com>
@shelar1423 shelar1423 requested review from benoitf and a team as code owners October 5, 2023 12:03
@shelar1423 shelar1423 requested review from cdrage and lstocchi and removed request for a team October 5, 2023 12:03
@shelar1423
Copy link
Contributor Author

@benoitf have a look and let me know the chnages required.

EXTENSIONS.md Outdated Show resolved Hide resolved
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
@benoitf benoitf changed the title Document: ammended "hidden feature" in EXTENSIONS.md chore: document property setting in EXTENSIONS.md Oct 5, 2023
@benoitf benoitf enabled auto-merge (squash) October 5, 2023 12:09
@benoitf benoitf merged commit 4e62066 into containers:main Oct 5, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.5.0 milestone Oct 5, 2023
@shelar1423
Copy link
Contributor Author

@benoitf can you please add the hacktoberfest labels to this pr

@shelar1423
Copy link
Contributor Author

hey @benoitf sorry to distrub you again but i was reading the rules for pr to be accepted it statest pr should have hacktoberfest-accepted label so if you could add that my pr will be counted..

@benoitf
Copy link
Collaborator

benoitf commented Oct 10, 2023

@shelar1423 done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: package.json titles are generated from key values + capitalization adds spacing
3 participants