feat: provider creation form #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
dgolovin,
jeffmaury,
lstocchi and
cdrage
and removed request for
a team,
benoitf,
dgolovin and
jeffmaury
Creating an instance of a Podman Machine or Kubernetes provider currently has a UI that doesn't quite match other places. Switching it to be a FormPage aligns the look and feel with the rest of our UI (header, breadcrumbs, etc.) and fixes things that we've already solved once in all the form pages, e.g. clicking Esc to close (#2853). Since this page was done a while ago there was some minor restructuring to make this happen: - The Resources page has to be marked as a details navigation hint so that the backlink/close button goes back to the correct page. - The code to find the provider display name and image (header info) is moved up from the connection creation page to the provider rendering form and onboardig. - This makes the provider image 'always hidden' on the component, so the property could be removed. Fixes #2853. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
force-pushed
the
machine-form
branch
from
ed75c89
to
0a49c56
Compare
Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
force-pushed
the
machine-form
branch
from
2ce4a3f
to
3429d9b
Compare
lstocchi
approved these changes
Oct 13, 2023
|
Noted. I confirmed it is picking up the 'correct' color and it is the same as the top was before, so I think we review the design with Mo later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creating an instance of a Podman Machine or Kubernetes provider had a UI that didn't quite match other places. Switching it to be a FormPage aligns the look and feel with the rest of our UI (header, breadcrumbs, etc.) and fixes things that we've already solved once in all the form pages, e.g. clicking Esc to close (#2853).
Since this page was done a while ago there was some minor restructuring to make this happen:
Screenshot/screencast of this PR
Before:
After:
Onboarding unchanged.
What issues does this PR fix or reference?
Fixes #2853.
How to test this PR?
Create a Podman machine or Kubernetes provider.