New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: header line height issue #4494
Conversation
@singodiyashubham87 FYI you'll need to add a SignedOff to your commit (so PR check DCO will be ✅ ) |
@benoitf I've already made the commit, how can I edit the commit message now to add my SignedOff? |
You can amend your commit and force push it to your branch |
@benoitf Okay, I'll do this now. |
c4f7c77
to
6c757b5
Compare
@benoitf I have added my signature still the check is failing, why? |
@singodiyashubham87 it requires a blank line before SignedOff In your commit you used a very long line |
a974c35
to
4a95579
Compare
@benoitf The commit is proper now, I have added an empty line before Signature, but the test is still failing. |
@singodiyashubham87 you can find more info here https://github.com/containers/podman-desktop/pull/4494/checks?check_run_id=18026745941 The proper format should be |
4a95579
to
6b4c918
Compare
@lstocchi I have modified the commit again. |
Sorry i just gave a quick look and i thought the problem was only the missing As said above the page https://github.com/containers/podman-desktop/pull/4494/checks?check_run_id=18026745941 gives you more details
|
Signed-off-by: singodiyashubham87 <singodiyashubham87@gmail.com>
6b4c918
to
514f2a7
Compare
What does this PR do?
I have fixed the spacing issue in the header.
Screenshot/screencast of this PR
Old
New
What issues does this PR fix or reference?
Fix #4485
How to test this PR?
Check the rendered website