Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header line height issue #4494

Merged
merged 1 commit into from Oct 25, 2023
Merged

Conversation

singodiyashubham87
Copy link
Contributor

What does this PR do?

I have fixed the spacing issue in the header.

Screenshot/screencast of this PR

Old

image

New

image

What issues does this PR fix or reference?

Fix #4485

How to test this PR?

Check the rendered website

@singodiyashubham87 singodiyashubham87 requested review from dgolovin and cdrage and removed request for a team October 24, 2023 13:21
@benoitf
Copy link
Collaborator

benoitf commented Oct 24, 2023

@singodiyashubham87 FYI you'll need to add a SignedOff to your commit (so PR check DCO will be ✅ )

@benoitf
Copy link
Collaborator

benoitf commented Oct 24, 2023

@singodiyashubham87
Copy link
Contributor Author

@benoitf I've already made the commit, how can I edit the commit message now to add my SignedOff?

@benoitf
Copy link
Collaborator

benoitf commented Oct 24, 2023

You can amend your commit and force push it to your branch

@singodiyashubham87
Copy link
Contributor Author

@benoitf Okay, I'll do this now.

@singodiyashubham87
Copy link
Contributor Author

@benoitf I have added my signature still the check is failing, why?

@benoitf
Copy link
Collaborator

benoitf commented Oct 24, 2023

@singodiyashubham87 it requires a blank line before SignedOff

In your commit you used a very long line

@singodiyashubham87
Copy link
Contributor Author

@benoitf The commit is proper now, I have added an empty line before Signature, but the test is still failing.
image

@lstocchi
Copy link
Contributor

lstocchi commented Oct 25, 2023

@singodiyashubham87 you can find more info here https://github.com/containers/podman-desktop/pull/4494/checks?check_run_id=18026745941

The proper format should be
Signed-off-by: Shubham Sindodiya <sindodiyashubham87@gmail.com>

@singodiyashubham87
Copy link
Contributor Author

@lstocchi I have modified the commit again.

@lstocchi
Copy link
Contributor

@lstocchi I have modified the commit again.

Sorry i just gave a quick look and i thought the problem was only the missing <>

As said above the page https://github.com/containers/podman-desktop/pull/4494/checks?check_run_id=18026745941 gives you more details

Expected "singodiyashubham87 [singodiyashubham87@gmail.com](mailto:singodiyashubham87@gmail.com)", 
but got "Shubham Singodiya [singodiyashubham87@gmail.com](mailto:singodiyashubham87@gmail.com)".

Signed-off-by: singodiyashubham87 <singodiyashubham87@gmail.com>
@singodiyashubham87
Copy link
Contributor Author

@benoitf @lstocchi Done!

@benoitf benoitf merged commit 17303db into containers:main Oct 25, 2023
12 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give proper spacing in header to avoid overlapping
4 participants