feat: add open created pod details #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
requested review from
jeffmaury and
cdrage
and removed request for
a team
deboer-tim
reviewed
Oct 25, 2023
|
Can we have unit tests ? |
They are in progress |
|
@jeffmaury added the unit test for the handling "Open Pod" button |
jeffmaury
requested changes
Oct 26, 2023
jeffmaury
reviewed
Oct 30, 2023
vzhukovs
force-pushed
the
pd#1470
branch
2 times, most recently
from
f60635a
to
ff13415
Compare
deboer-tim
approved these changes
Jan 16, 2024
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
|
@jeffmaury can we proceed to merge? |
LGTM for me but you should contact @benoitf is this should land in 1.7.0 |
benoitf
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds "Open Pod" button after deploying generated pod to the Kubernetes.
Screenshot/screencast of this PR
Additional button in the bottom right corner:
After clicking on "Open Pod" it navigates to the pod details:
What issues does this PR fix or reference?
fix #1470
How to test this PR?
Deploy existing container to the Kubernetes from the dropdown menu item "Deploy to Kubernetes", then when deployment is finished, an additional button should appear "Open Pod", which navigates to the newly deployed pod.