Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation regarding auto merge #4519

Merged
merged 1 commit into from Nov 1, 2023

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Oct 25, 2023

docs: update documentation regarding auto merge

What does this PR do?

Adds a disclaimer not to enable auto-merge unless a maintainer has
reviewed it.

Gives some feedback that reviews may be fast, but merging may be slow.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

### What does this PR do?

Adds a disclaimer not to enable auto-merge unless a maintainer has
reviewed it.

Gives some feedback that reviews may be fast, but merging may be slow.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast
explaining what is doing this PR -->

N/A

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

N/A

### How to test this PR?

<!-- Please explain steps to reproduce -->

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage requested review from benoitf and a team as code owners October 25, 2023 15:57
@cdrage cdrage requested review from dgolovin and feloy and removed request for a team October 25, 2023 15:57
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes except for typo/dependabot stuff auto merge should be only set after people had time to review it

@cdrage cdrage merged commit 8fbbf7a into containers:main Nov 1, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants