Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support in command palette for category #4531

Merged
merged 1 commit into from Oct 27, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 26, 2023

What does this PR do?

Display category provided by commands in the command palette as a prefix of command's title

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes #4106

How to test this PR?

unit test added

you can check the title when using podman desktop demo extension https://github.com/redhat-developer/podman-desktop-demo/tree/main/extension

bringing command palette should display these commands with Podman Desktop demo: prefix

fixes containers#4106
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner October 26, 2023 14:04
@benoitf benoitf requested review from jeffmaury and lstocchi and removed request for a team October 26, 2023 14:04
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 7fd5c47 into containers:main Oct 27, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commands: add category handle in package.json
5 participants