Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce website footer #4546

Merged
merged 2 commits into from Oct 30, 2023
Merged

fix: reduce website footer #4546

merged 2 commits into from Oct 30, 2023

Conversation

deboer-tim
Copy link
Collaborator

@deboer-tim deboer-tim commented Oct 27, 2023

What does this PR do?

Ok, here's my pass at reducing the vertical height of the footer. Long term I think we can and should do more, this is just a quick initial cleanup pass:

  • Left: removed three links (so both columns are down to 5). These are a judgement call, e.g. I felt like 'Docker migration' is a bit of marketing we'd want to leave for now.
  • Right: remove Blog (it's already at the top of the page).
  • Right: remove planning and roadmap, both not really useful link and accessible from the Github link above.
  • Put copyright and license on one line.

Overall, this reduces the footer height from 11 lines of text to 7.

Screenshot/screencast of this PR

Before:

Screenshot 2023-10-27 at 4 30 37 PM

After (updated to latest commit):

Screenshot 2023-10-30 at 2 43 53 PM

What issues does this PR fix or reference?

Fixes #4299.

How to test this PR?

yarn website:dev

Ok, here's my pass at reducing the vertical height of the footer. Long term I think
we can and should do more, this is just a quick initial cleanup pass:
- Left: removed three links (so both columns are down to 5). These are a
  judgement call, e.g. I felt like 'Docker migration' is a bit of marketing we'd
  want to leave for now.
- Right: remove Blog (it's already at the top of the page).
- Right: remove planning and roadmap, both not really useful link and accessible
  from the Github link above.
- Put copyright and license on one line.

Overall, this reduces the footer height from 11 lines of text to 7.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim requested review from jeffmaury and lstocchi and removed request for a team October 27, 2023 20:34
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO I think roadmap is interesting as a direct link

but probably for Chat, we should reduce the numbers of links as it looks like it's too many

@jeffmaury
Copy link
Contributor

IMHO I think roadmap is interesting as a direct link

but probably for Chat, we should reduce the numbers of links as it looks like it's too many

Keep the discord one and replace the others chat links by a link to https://github.com/containers/podman-desktop#communication

@deboer-tim
Copy link
Collaborator Author

@benoitf I didn't think the (previous link) was very useful. How about pointing them to the planning board or current sprint instead?

@jeffmaury Makes sense, will do.

@benoitf
Copy link
Collaborator

benoitf commented Oct 30, 2023

@deboer-tim yes as you suggested, we need a redirect link, current link is not good 👍 (I would prefer 'current sprint' link as default to backlog is not really great as well (you need to click on a link again)

I agree that footer links are like direct calls and as Jeff pointed out, when there are several links, just take one

Reduced four chat links to just Discord and a link to Communication section in the readme. Added back in a link to the sprint planning board.

Removed Compose from the doc links to even things out again.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim
Copy link
Collaborator Author

Pushed another commit:

  • Reduced four chat links to just Discord and a link to Communication section in the readme. Added back in a link to the sprint planning board.
  • Removed Compose from the doc links to even things out again.

@slemeur
Copy link
Collaborator

slemeur commented Oct 30, 2023

Good simplification!

@cdrage cdrage merged commit a0c81e2 into main Oct 30, 2023
13 checks passed
@cdrage cdrage deleted the footer branch October 30, 2023 23:25
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce website footer
6 participants