fix: report error if container engine action fails in details page (#3796) #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
requested review from
dgolovin and
feloy
and removed request for
a team
benoitf
reviewed
Nov 3, 2023
There was a problem hiding this comment.
it looks like the major part of this PR is about a code refactoring, then the report of the error is mainly about only adding
<ConnectionErrorInfoButton status="{connectionStatus}" /> but it's like hard to see what is new and what is refactoring
so I'm wondering if it should be split at least into two commits
Signed-off-by: lstocchi <lstocchi@redhat.com>
…ontainers#3796) Signed-off-by: lstocchi <lstocchi@redhat.com>
|
@benoitf done 👍 |
benoitf
approved these changes
Nov 3, 2023
deboer-tim
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the error button that get shown if a container action fails
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it resolves #3796
How to test this PR?