Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location of roots.exe in devmode #4654

Merged
merged 2 commits into from Nov 7, 2023
Merged

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Nov 4, 2023

What does this PR do?

fixes exception when retrieving CA on windows.

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

fix #4653.

How to test this PR?

Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin requested review from benoitf and a team as code owners November 4, 2023 06:52
@dgolovin dgolovin requested review from jeffmaury and feloy and removed request for a team November 4, 2023 06:52
@benoitf benoitf requested a review from lstocchi November 4, 2023 14:23
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Denis, this is an error i always saw but never had the time to look at. 🚀
LGTM, with Jeff suggestion it would be even better

Co-authored-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Denis Golovin <dgolovin@users.noreply.github.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit b685507 into containers:main Nov 7, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faiure to extract CA on windows in dev mode
4 participants