fix: use URL for proxy specification and add validation #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmaury
requested review from
dgolovin and
lstocchi
and removed request for
a team
lstocchi
reviewed
Nov 16, 2023
lstocchi
reviewed
Nov 16, 2023
dgolovin
requested changes
Nov 16, 2023
dgolovin
approved these changes
Nov 20, 2023
Fixes containers#4810 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4810
What does this PR do?
Ensure proxy addresses are now URLs; convert previous values and add validation in the settings screen
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #4810
How to test this PR?
Go to the proxy settings page