New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain how to create an onboarding workflow for an extension (#3440) #4837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always nice to have documentation 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this documentation 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes suggested, also need to deal with the PR check errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small Vale error this looks great!
@themr0c do you know why vale is erroring? When i run vale locally it doesn't find any errors, so i don't get the failing gh action workflow here. What do i have to do to fix it? Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM. Please figure out how to resolve Vale error before merging though.
For the record N.B. is correct in English too, just not very common and potentially confusing in Canada. ;-)
Did you try to use absolute paths for links? There are many errors like this one, can this be cause of vale erroring?
|
Here it's a vale check error on links 🤦♀️ |
…ontainers#3440) Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
the weird thing is that in all other pages with images this is how links are. So i just copied/paste it. Now i tried to add the |
Signed-off-by: lstocchi <lstocchi@redhat.com>
I remember a message saying in the log: "error: too many warnings". The links you had added probably exceeded the threshold |
no idea what was the problem. bc there was specified a limit of 10 and i was sure i only had 10 warnings. Maybe there was something else 🤷♂️ btw thanks @feloy , it worked 👍 |
What does this PR do?
It adds the documentation to show how to add an onboarding workflow to an extension
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
it resolves #3440
How to test this PR?
N/A