Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to create an onboarding workflow for an extension (#3440) #4837

Merged
merged 5 commits into from Dec 1, 2023

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

It adds the documentation to show how to add an onboarding workflow to an extension

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

it resolves #3440

How to test this PR?

N/A

@lstocchi lstocchi marked this pull request as ready for review November 17, 2023 10:45
@lstocchi lstocchi requested review from dgolovin and feloy and removed request for a team November 17, 2023 10:45
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always nice to have documentation 🎉

website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this documentation 💯

website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
@lstocchi lstocchi requested a review from feloy November 17, 2023 11:50
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes suggested, also need to deal with the PR check errors.

website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
website/docs/extensions/write/onboarding-workflow.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small Vale error this looks great!

@lstocchi
Copy link
Contributor Author

@themr0c do you know why vale is erroring? When i run vale locally it doesn't find any errors, so i don't get the failing gh action workflow here. What do i have to do to fix it? Thanks!!

Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM. Please figure out how to resolve Vale error before merging though.

For the record N.B. is correct in English too, just not very common and potentially confusing in Canada. ;-)

@feloy
Copy link
Contributor

feloy commented Nov 30, 2023

Did you try to use absolute paths for links? There are many errors like this one, can this be cause of vale erroring?

Raw Output:
  {"message": "[RedHat.TermsWarnings] Consider using 'such as' rather than 'like' unless updating existing content that uses the term.", "location": {"path": "website/docs/extensions/write/onboarding-workflow.md", "range": {"start": {"line": 378, "column": 151}}}, "severity": "WARNING"}
  Warning: [vale] reported by reviewdog 🐶
  [PodmanDesktop.Links] Consider starting the link with https:// or /, rather than ](img/button_micromark.png)

@benoitf
Copy link
Collaborator

benoitf commented Nov 30, 2023

Here it's a vale check error on links 🤦‍♀️

Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi
Copy link
Contributor Author

lstocchi commented Dec 1, 2023

Did you try to use absolute paths for links? There are many errors like this one, can this be cause of vale erroring?

Raw Output:
  {"message": "[RedHat.TermsWarnings] Consider using 'such as' rather than 'like' unless updating existing content that uses the term.", "location": {"path": "website/docs/extensions/write/onboarding-workflow.md", "range": {"start": {"line": 378, "column": 151}}}, "severity": "WARNING"}
  Warning: [vale] reported by reviewdog 🐶
  [PodmanDesktop.Links] Consider starting the link with https:// or /, rather than ](img/button_micromark.png)

the weird thing is that in all other pages with images this is how links are. So i just copied/paste it. Now i tried to add the /, let's see if it becomes green

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi enabled auto-merge (squash) December 1, 2023 14:17
@lstocchi lstocchi merged commit ef4e857 into containers:main Dec 1, 2023
13 of 14 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Dec 1, 2023
@feloy
Copy link
Contributor

feloy commented Dec 1, 2023

Did you try to use absolute paths for links? There are many errors like this one, can this be cause of vale erroring?

Raw Output:
  {"message": "[RedHat.TermsWarnings] Consider using 'such as' rather than 'like' unless updating existing content that uses the term.", "location": {"path": "website/docs/extensions/write/onboarding-workflow.md", "range": {"start": {"line": 378, "column": 151}}}, "severity": "WARNING"}
  Warning: [vale] reported by reviewdog 🐶
  [PodmanDesktop.Links] Consider starting the link with https:// or /, rather than ](img/button_micromark.png)

the weird thing is that in all other pages with images this is how links are. So i just copied/paste it. Now i tried to add the /, let's see if it becomes green

I remember a message saying in the log: "error: too many warnings".

The links you had added probably exceeded the threshold

@lstocchi
Copy link
Contributor Author

lstocchi commented Dec 1, 2023

I remember a message saying in the log: "error: too many warnings".

The links you had added probably exceeded the threshold

no idea what was the problem. bc there was specified a limit of 10 and i was sure i only had 10 warnings. Maybe there was something else 🤷‍♂️ btw thanks @feloy , it worked 👍

@lstocchi lstocchi deleted the i3440 branch December 1, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: document how the onboarding works/how to create an onboarding workflow
6 participants