Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain autostart setting (#4647) #4879

Merged
merged 1 commit into from Nov 21, 2023
Merged

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

This PR cleans the code that defines the autostart setting and fixes a problem when storing its value.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

it fixes #4647

How to test this PR?

  1. check that the autostart setting is actually saved
  2. set autostart, stop machine, restart podman desktop, check that the autostart setting is true and the podman machine is started
  3. set autostart to false, stop machine, restart desktop, check autostart setting is false and the podman machine is still stopped.

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners November 20, 2023 13:32
@lstocchi lstocchi requested review from jeffmaury and cdrage and removed request for a team November 20, 2023 13:32
@benoitf
Copy link
Collaborator

benoitf commented Nov 20, 2023

I have a question, I see lot of people still using old versions

here it looks like if we remove all properties, users migrating from an old version will have their autostart setting being ignored ?

@lstocchi
Copy link
Contributor Author

@benoitf ppl that uses the old version will end up to a true value.
Having both complicates the code and we agreed on moving on specific provider autostart setting.
As the autostart is not working as expected i think it's a good time to remove old code and start from 0 again. The worst scenario is that people will see the autostart setting enabled if they set it to false using the old version, but we can say there was a bug and it was fixed. If you disable it again, it will work fine.

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 4eaad69 into containers:main Nov 21, 2023
9 checks passed
@lstocchi lstocchi deleted the i4647 branch November 21, 2023 12:30
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman Desktop doesn't retain autostart setting
4 participants