Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update Mac OS getting-started content #493

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

deekay2310
Copy link
Contributor

Signed-off-by: Dev Kumar devskumar99@gmail.com

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Signed-off-by: Dev Kumar <devskumar99@gmail.com>
@slemeur slemeur changed the title website: suggested changes by Stevan Update Mac OS getting-started content Sep 29, 2022
@@ -5,8 +5,6 @@ sidebar_position: 3
# MacOS
## Installing Podman Desktop on MacOS using .dmg file

#### Prerequisite: Podman Machine

If you already have a Podman machine up and running, you can check out the [Downloads](/downloads/macos) section of this website to get the applicable .dmg file depending on your Mac Hardware Architecture (i.e. Intel or Apple M1).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the first thing the reader will read.
If I'm new to podman, I'd have no idea what a "podman machine" is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, there are multiple binaries, the document should explain to the reader how to chose the right one. The universal binary being here to simplify things, so the user does not have to worry/know about which architecture they have (--> should be the default/recommended path).

@@ -5,8 +5,6 @@ sidebar_position: 3
# MacOS
## Installing Podman Desktop on MacOS using .dmg file

#### Prerequisite: Podman Machine

If you already have a Podman machine up and running, you can check out the [Downloads](/downloads/macos) section of this website to get the applicable .dmg file depending on your Mac Hardware Architecture (i.e. Intel or Apple M1).

If you are new to Podman and do not have a Podman Machine up and running, fret not. Downloading and Installing Podman Desktop allows you to get all the dependencies as well.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we even mention "podman machine" here?

website/docs/Installation/macos-install.md Show resolved Hide resolved
@benoitf benoitf changed the title Update Mac OS getting-started content website: Update Mac OS getting-started content Sep 29, 2022
Signed-off-by: Dev Kumar <devskumar99@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@deekay2310
Copy link
Contributor Author

@slemeur have added about view detection checks and removed details about the 'machine'

deekay2310 and others added 2 commits September 29, 2022 13:22
Signed-off-by: Dev Kumar <devskumar99@gmail.com>
Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
@deekay2310
Copy link
Contributor Author

@benoitf can we merge?

Copy link
Collaborator

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekay2310 deekay2310 merged commit 71a59a9 into containers:main Oct 4, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.9.0 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants