-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Update Mac OS getting-started content #493
Conversation
Signed-off-by: Dev Kumar <devskumar99@gmail.com>
@@ -5,8 +5,6 @@ sidebar_position: 3 | |||
# MacOS | |||
## Installing Podman Desktop on MacOS using .dmg file | |||
|
|||
#### Prerequisite: Podman Machine | |||
|
|||
If you already have a Podman machine up and running, you can check out the [Downloads](/downloads/macos) section of this website to get the applicable .dmg file depending on your Mac Hardware Architecture (i.e. Intel or Apple M1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the first thing the reader will read.
If I'm new to podman, I'd have no idea what a "podman machine" is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, there are multiple binaries, the document should explain to the reader how to chose the right one. The universal binary being here to simplify things, so the user does not have to worry/know about which architecture they have (--> should be the default/recommended path).
@@ -5,8 +5,6 @@ sidebar_position: 3 | |||
# MacOS | |||
## Installing Podman Desktop on MacOS using .dmg file | |||
|
|||
#### Prerequisite: Podman Machine | |||
|
|||
If you already have a Podman machine up and running, you can check out the [Downloads](/downloads/macos) section of this website to get the applicable .dmg file depending on your Mac Hardware Architecture (i.e. Intel or Apple M1). | |||
|
|||
If you are new to Podman and do not have a Podman Machine up and running, fret not. Downloading and Installing Podman Desktop allows you to get all the dependencies as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we even mention "podman machine" here?
Signed-off-by: Dev Kumar <devskumar99@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@slemeur have added about view detection checks and removed details about the 'machine' |
Signed-off-by: Dev Kumar <devskumar99@gmail.com>
Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
@benoitf can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dev Kumar devskumar99@gmail.com
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?