fix: fix succeeded/completed state for Compose onboarding #4947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
requested review from
dgolovin,
lstocchi,
cdrage and
deboer-tim
and removed request for
a team
lstocchi
approved these changes
Nov 22, 2023
cdrage
approved these changes
Nov 22, 2023
benoitf
approved these changes
Nov 22, 2023
|
I don't know if it's possible one day, but could be interesting to test the onboarding with unit test like new OnboardingTestHelper('..') then we provide fake commands, etc and see if we're called as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin phmartin@redhat.com
What does this PR do?
This PR fixes the
state=succeededfor Compose onboarding.What issues does this PR fix or reference?
How to test this PR?