nit: table column overlapping and aria roles #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are already proposed in PRs #4844 and #4841 respectively, but since those PRs are taking a while in review and these changes are required for other PRs I'm breaking them out here: - Add missing aria roles to the first two cells in the column. (Not only is this correct, but lack of them breaks e2e tests). - Add max-w-full to each cell, so that the overflow-hidden applies correctly and cells that are too narrow are cropped instead of overlapping. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
feloy
and removed request for
a team
benoitf
approved these changes
Nov 22, 2023
|
unit test to grab the cell role ? |
feloy
approved these changes
Nov 22, 2023
Added columnheader role to future-expander column for consistency and added tests for aria roles. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Added aria role to first column (future section expander) to keep things consistent, and added tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes are already proposed in PRs #4844 and #4841 respectively, but since those PRs are taking a while in review and these changes are common and required for other PRs I'm breaking them out here:
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Issues raised during reviews of the mentioned PRs.
How to test this PR?
See issues in the PRs. e.g. to test overflow try #4841 with a long volume name and narrow columns, with or without this change.