New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactored _setting up container registries_ #4965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the tone of the tutorial and think it is clean and well written - but I have to admit I wasn't expecting it to mean that all previous content on the topic would be removed (replaced by the tutorial).
My only real concern is whether a user on any particular OS who (e.g.) 'just wants to setup a registry' will be able to easily find and consume that particular snippet of content in the middle of the tutorial, or whether there are some parts of the tutorial we should keep as direct how-to content. Might need to sleep on it or get other opinions.
I don't understand. It was clearly stated in the initial Gdoc that the intent was to replace the current content. |
I agree with Tim. I do not think the tutorial is an improvement but rather makes it more confusing, I liked how we had tabbed sections for Windows / Linux / macOS as it differentiated between the three, but now it's in a bullet point form again (how it was previously) to showcase the differences. |
We are leaning toward a form of documentation that is less of an "instructional tone" to be more guided and end-goal centric. Going that direction is also about making the documentation more approachable and informative, but still providing clear step-by-step instructions. The content is structured to facilitate ease of understanding with a user-friendly tone which will result in a more engaging documentation. The issue we have with the current organization of the documentation is that we have a lot of pages and sub-ages and it makes it particularly hard to read through it or to find information. We could improve the way we separate information depending on the platform. We could integrate inline tabs per OS, each time we have different instructions for each platform. |
I really prefer this form of writing the docs; the language and way it's approached feels friendlier and more accessible. This is excellent work @themr0c ! Some UX-minded suggestions:
|
c05fdfc
to
1382d2a
Compare
Updated with tabs. |
NB: Vale errors are mistakes, see #4498. |
Looks better with the tabs for me |
1e39f04
to
f912844
Compare
Updated teh overview section. @slemeur @deboer-tim is that mergeable now? |
Vale is so chatty and verbose it's hard to see what you changed in each commit, that's probably something we should address separately. :-( You'll also need to make it happy to pass PR checks. +1 to removing 'Who this is for'. It kind of feels like it just got merged into the overview though, which is getting a bit long IMHO. I would prefer to just remove the first two paragraphs - the first is generic and applies to everything in PD, the second is basically what was in the 'who is this for' and anyone looking for this doc will already know it's for them (or it's evident from the rest of the overview). I would really like to simplify the titles so that I can scan the list on the right to jump to a specific section. e.g. right now most of them start with 'Setting up a'/'Verifying your' so it's hard to quickly find a section like 'insecure registry'. |
I am not ready to give up on effective titles starting with a gerund. This is a good rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intro has to be more direct and easy to scan.
Most of the time, the reader will come to the page, with "one need". With the current state, we are requiring the reader to read a long set of sentences to "identify" what's in the documentation page. It's not efficient.
Titles are also redundant and must more direct.
if easier - we could consider removing the overview paragraph. |
Can we stay with what we agreed on last Thursday, avoid another round of changes, and merge as good enough, please? |
"Setting up insecure registries" or "How to setup an insecure registry" provides zero additional value or clarity to the intended audience. If they're scanning for words like 'insecure' or 'authentication', it's hurting them because they need to read twice as many words to find what they're looking for. Take a look at some random docs from equivalent sites - no gerund, just succinct titles: |
Gerund or not, the presence of a verb to start a procedure title is a well-established convention. The two shared Docker and IntelliJ docs examples are inconsistent outliers in documentation sets that are following this convention. See in other pages: "Build the image", "Run the container", "Add stages", "Speed up indexing", etc. Stripe docs have an excellent reputation, and follow the same rule. For example: https://stripe.com/docs/development/quickstart The VSCode docs have a reputation to be generally inconsistent, and are not an example to follow for good practice. |
I didn't hunt for outliner pages, those were just the first ones I found that had lots of topics. Personally I find Stripe wordy. But either way, all of these examples have much shorter titles without repetition. |
@deboer-tim ^ some proposals to get titles shorter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
fde40cd
to
8cf268d
Compare
Wow, local rebase required to pass format linter test did reset all commit dates, strange. |
@slemeur @deboer-tim @benoitf I am missing the authority to validate Argos changes. Can you please provide me the accreditation? |
@themr0c argos is not a required check (but you should have received a message long time ago to join an argos team) |
What does this PR do?
Understanding the registry configuration.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?