chore: default volume sort #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that both #4841 (Volume table component) and #4860 (default sort column) have merged, we can follow up and mark the default sort column for volumes: name. This change has no effect other than setting the sort indicator for the Volumes column by default. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
feloy
and removed request for
a team
benoitf
approved these changes
Nov 23, 2023
feloy
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now that both #4841 (Volume table component) and #4860 (default sort column) have merged, we can follow up and mark the default sort column for volumes: name. This change has no effect other than setting the sort indicator for the Name column by default.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A
How to test this PR?
Open Volumes page, see Name sort indicator.