-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test,ci): fix broken e2e test execution #5003
chore(test,ci): fix broken e2e test execution #5003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it only needs to be done once, so it should not be done at each run of the test command
@benoitf It does not force overwrite the artifacts, so if it is called twice, it does not do anything if already up to date. |
move it to |
@benoitf Nice, neat. |
09d4934
to
af0d4fa
Compare
af0d4fa
to
17ede5f
Compare
0ef340a
to
56a56f8
Compare
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
56a56f8
to
c2f179c
Compare
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#4983
#5032
How to test this PR?