New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provider cards #5013
feat: provider cards #5013
Conversation
The docs / resources links are kinda awkward (they were in the mockup too!) I am wondering, can we put them under a kebab menu in the upper right corner of the card for each? |
Also for podman - can we just drop to the podman logomark? We don't need the logotype (this is the same approach as on settings > resources) |
Ahhh one more thing. Sorry. We should have a link to settings > resources. One idea would be to put these cards in an encapsulating box and put a manage ... button attached to the upper right of the encapsulating box... and that would go to settings > resources. something like this (I worked in the kebabs too so you could see how it might look): |
I've opened #5099 to switch to using the square logos, since it is independent to this PR. This PR is really just to get a common component/layout between the cards. I can see if some of the new design is easy to incorporate, but the rest should go in following PRs. The new design doesn't match what's in issue #4395 though, so we should either update that or create another issue so this design is not lost. FWIW I like the cleanliness and simplicity, but there is still other information (e.g. see Podman and OpenShift Local above) where we need to decide where else to put the actions or if they can be dropped. There is also no 'reconnect' action or link icons today. |
@deboer-tim cool I can put this new mockup there - apologies for this, i wasn't quite happy with the original mockup. re: the extra functionality - i have this issue: the thought is:
|
can be follow-up PRs, etc but probably need to land after 1.6 is cut |
Creates a ProviderCard component and makes each of the Provider* components use it in order to get some common layout and code between the different states. With the card I tried to make it more like the example in #4395 and our other cards (e.g. Resources, Kubernetes contexts, or CLI), creating two columns with the first having the common bits: logo at the top-left corner with the name and version, with status below it, and the right containing everything else that is specific to the state. The existing status dots + text components don't quite work for providers so I created a new one. Need to review this, overall componentization, and create tests for ProviderCard before raising for official review. Signed-off-by: Tim deBoer <git@tdeboer.ca>
ffee3e1
to
383b483
Compare
Signed-off-by: Tim deBoer <git@tdeboer.ca>
Rebased, force pushed, and fixed missing aria region to fix e2e tests. Ready for official review. To reiterate, this is not implementing the full nor final design: it is moving everything to a single component and doing the most basic part of the design change, to make it easier and cleaner for future PRs under #4395 to continue the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProviderCard has no tests
Basic tests for aria region, name, version/no-version, and state added. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Signed-off-by: Tim deBoer <git@tdeboer.ca>
What does this PR do?
Creates a ProviderCard component and makes each of the Provider* components use it in order to get some common layout and code between the different states.
With the card I tried to make it more like the example in #4395 and our other cards (e.g. Resources, Kubernetes contexts, or CLI), creating two columns with the first having the common bits: logo at the top-left corner with the name and version, with status below it, and the right containing everything else that is specific to the state.
The existing status dots + text components don't quite work for providers so I created a new one. Need to review this, overall componentization, and create tests for ProviderCard before raising for official review.
Screenshot/screencast of this PR
Before:
After:
What issues does this PR fix or reference?
Fixes most of #4395. IMHO we should still remove a link or two from providers, and the horizontal Podman/Docker logos should be changed to regular square logos like the other providers.
How to test this PR?
yarn test:renderer
and view Dashboard for any UI issues.