fix: container tabs should match pods #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we made the container All/Running/Stopped tabs we used 'containers' in each tab title. By the time we did pods we just used All/Running/Stopped. This just cleans up the Containers page to be consistent with Pods and have less redundant tabs. Fixes #4925. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
Signed-off-by: Tim deBoer <git@tdeboer.ca>
dgolovin
approved these changes
Nov 30, 2023
benoitf
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we made the container All/Running/Stopped tabs we used 'containers' in each tab title. By the time we did pods we just used All/Running/Stopped. This just cleans up the Containers page to be consistent with Pods and have less redundant tabs.
Screenshot/screencast of this PR
See issue #4925.
What issues does this PR fix or reference?
Fixes #4925.
How to test this PR?
Page between Containers list and Pods list to see consistent tab filters.