fix: path may not be accurate on macOS for Docker Extensions #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on macOS, electron is not using user PATH fixes containers#508 Change-Id: I47d65a45eb126bdf36f34eb69fe5a0340566ddf7 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
on macOS, electron is not using user PATH
fixes #508
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#508
How to test this PR?
Use production mode, not development mode else for sure it contains the right env/PATH.
Change-Id: I47d65a45eb126bdf36f34eb69fe5a0340566ddf7
Signed-off-by: Florent Benoit fbenoit@redhat.com