fix: table headers shouldn't allow text selection #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
dgolovin and
cdrage
and removed request for
a team
deboer-tim
force-pushed
the
table-header
branch
from
6f28863
to
83c59b6
Compare
Our column headers shouldn't allow you to select the text, and sortable columns should have a pointer cursor. Added another unsortable column to test table to extend tests. Fixes #5114. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
force-pushed
the
table-header
branch
from
83c59b6
to
a29a75b
Compare
lstocchi
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our column headers shouldn't allow you to select the text, and sortable columns should have a pointer cursor.
Added another unsortable column to test table to extend tests.
Screenshot / video of UI
Screen.Recording.2023-12-04.at.5.25.59.PM.mov
What issues does this PR fix or reference?
Fixes #5114.
How to test this PR?
Go to Volumes page.