Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not change color and underline of markdown buttons #5138

Merged
merged 1 commit into from Dec 6, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Dec 5, 2023

What does this PR do?

do not change color and underline of markdown buttons (the one with href)

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #5137

How to test this PR?

Check the button has white color and not underlined on hover

fixes containers#5137
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner December 5, 2023 20:57
@benoitf benoitf requested review from jeffmaury and lstocchi and removed request for a team December 5, 2023 20:57
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Florent!!

@benoitf benoitf merged commit 695c9ea into containers:main Dec 6, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown button with href is not rendered properly
4 participants