Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset loggerhandlerKey after restarting machine (#5150) #5168

Merged
merged 2 commits into from Dec 8, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Dec 7, 2023

What does this PR do?

it resets the loggerHandlerKey which is used when restarting a podman machine. As that was not reset the startAction was called twice, resulting in a failure the second time as the machine was already running

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

it resolves #5150

How to test this PR?

  1. restart a podman machine from its details page

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners December 7, 2023 10:13
@lstocchi lstocchi requested review from jeffmaury and cdrage and removed request for a team December 7, 2023 10:13
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

could you please add a test where we reproduce the bug so if someone do some a refactoring, we won't have again this problem ?

check we don't have the two actions loop

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from benoitf December 7, 2023 16:44
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lstocchi

@benoitf benoitf merged commit ae2c861 into containers:main Dec 8, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Dec 8, 2023
This was referenced Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Success icon displayed after podman machine restart failure
3 participants