feat: show lima instance name in connection name #5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
dgolovin and
feloy
and removed request for
a team
benoitf
reviewed
Dec 14, 2023
|
It didn't have any tests at all, as far as I could see? |
|
yes I think at some time we had no test for some extension but now (since almost one year) we're requesting tests for new code change so each time we change something, we add some unit test so it increases regression tests |
afbjorklund
force-pushed
the
lima-name
branch
2 times, most recently
from
eb919e1
to
6aa446a
Compare
afbjorklund
force-pushed
the
lima-name
branch
2 times, most recently
from
c208262
to
c4ffa87
Compare
benoitf
approved these changes
Feb 27, 2024
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows the name of the preferred instance
Lima ${LIMA_INSTANCE}Screenshot / video of UI
What issues does this PR fix or reference?
Closes: #5207
How to test this PR?