fix: try to search kubectl on the user path first #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
register/set version/path from existing binary first fixes containers#5216 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
dgolovin,
lstocchi and
deboer-tim
and removed request for
a team
cdrage
approved these changes
Dec 13, 2023
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
deboer-tim
approved these changes
Dec 13, 2023
|
I would need a test on WIndows if possible |
4 tasks
|
Tested on Windows. Was able to find the kubectl I had on my PATH |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
register/set version/path from existing binary first
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #5216
How to test this PR?
unit test
check usecase from the issue
also check with an old binary, try to update it, without binary/cache from ~/.local/share/containers/podman-desktop/extensions-storage/