fix: providerinfo badge #5268
Merged
fix: providerinfo badge #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProviderInfo was built for pods, where the .kind is 'podman' or 'kubernetes'. For images, .engineName is 'Podman'. Simple fix to base color on lowercased provider name. Tests added. Some unrelated tests aren't passing a provider, so that's why the '?'. Fixes #5264. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
approved these changes
Dec 14, 2023
lstocchi
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ProviderInfo was built for pods, where the .kind is 'podman' or 'kubernetes'. For images, .engineName is 'Podman'. Simple fix to base color on lowercased provider name.
Tests added. Some unrelated tests aren't passing a provider, so that's why the '?'.
Screenshot / video of UI
The dot changes color, see #5264.
What issues does this PR fix or reference?
Fixes #5264.
How to test this PR?
Go to Images page, Podman environment badges now purple.