Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to select how to open devtools in dev mode #5274

Merged
merged 1 commit into from Dec 15, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Dec 15, 2023

What does this PR do?

allow to select how to open dev tools at startup in dev mode

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #5031

How to test this PR?

use development mode, and change options (settings/preferences)

unit tests provided

@benoitf benoitf requested a review from a team as a code owner December 15, 2023 07:53
@benoitf benoitf requested review from jeffmaury, cdrage and odockal and removed request for a team December 15, 2023 07:53
@odockal
Copy link
Contributor

odockal commented Dec 15, 2023

I tried to build it locally and it works as expected. In yarn watch I can setup the devtools options.

@odockal
Copy link
Contributor

odockal commented Dec 15, 2023

Also If I compile and PD locally, it does not offer the option for opening the dev tools.
LGTM

@benoitf benoitf merged commit 3c6708f into containers:main Dec 15, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.7.0 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants