fix: empty screen reset filter by default #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
dgolovin and
cdrage
and removed request for
a team
deboer-tim
force-pushed
the
empty-filter
branch
from
8807034
to
baa790b
Compare
benoitf
reviewed
Dec 19, 2023
|
👍 |
Fixes the regression caused by #4600. Prior to this the FilteredEmptyScreen would reset all filters to ''. The container list needed special processing to not remove the filters like 'is:running' so it was changed to an event, but none of the other lists respond to this event so none of the filters get cleared. This sets a default behaviour of clearing the list so that none of the other lists need to respond to the event if they are fine just clearing the filter. If you do your own special processing, you just call e.preventDefault(). The search term is included as an event property because we need to set cancelable in the third argument. The pods list has the tabs/is:running so I added the event handling there as well. Without this change clearing the filter would always return you to the first tab. Fixes #5288. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
force-pushed
the
empty-filter
branch
from
baa790b
to
2fc1ab7
Compare
|
Rebased to latest and added regression and non-regression tests. |
lint and format don't agree, use disable to allow double quotes. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the regression caused by #4600. Prior to this the FilteredEmptyScreen would reset all filters to ''. The container list needed special processing to not remove the filters like 'is:running' so it was changed to an event, but none of the other lists respond to this event so none of the filters get cleared.
This sets a default behaviour of clearing the list so that none of the other lists need to respond to the event if they are fine just clearing the filter. If you do your own special processing, you just call e.preventDefault(). The search term is included as an event property because we need to set cancelable in the third argument.
The pods list has the tabs/is:running so I added the event handling there as well. Without this change clearing the filter would always return you to the first tab.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #5288.
How to test this PR?
Enter random text in container, pods, and volumes/images view, and confirm that clearing the filter works (and leaves the is:running/stopped for containers/pods list).