docs: message when the app terminates because another instance exists #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
requested review from
dgolovin and
jeffmaury
and removed request for
a team
benoitf
approved these changes
Dec 21, 2023
jeffmaury
approved these changes
Dec 21, 2023
packages/main/src/index.ts
Outdated
| @@ -48,6 +48,7 @@ const additionalData: AdditionalData = { | |||
| // provide additional data to the second instance | |||
| const isSingleInstance = app.requestSingleInstanceLock(additionalData); | |||
| if (!isSingleInstance) { | |||
| console.log('An instance of Podman Desktop is already running. Stopping'); | |||
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin phmartin@redhat.com
What does this PR do?
This PR adds a message on the console before the app terminates when an instance already exists.
I needed a few hours to understand why my debug sessions were failing on Windows. I had installed a production version of Podman Desktop, and didn't realize it was running in the background, and prevented from starting other development sessions.
This message would help me or other people understand more easily the next time it happens.