feat: adding groupContributions logic #5415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
cdrage and
lstocchi
and removed request for
a team
|
IMHO the kebab still needs the darker box in this context so that it looks like a button. |
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
I updated the design and added unit tests! |
lstocchi
reviewed
Jan 4, 2024
I am gonna take a look |
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
…oupContributions off Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
|
@lstocchi I fix it and added a test ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding logic to groups contributions with a kebab style when more than one contribution are present in ImageDetails
Screenshot / video of UI
only one action contribution
more than one
What issues does this PR fix or reference?
Fix #5313