New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve Authentication Providers page #5424
feat: improve Authentication Providers page #5424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍🏼 to change. 2 nits though:
We should really switch this to use IconImage too, but that's a different PR. |
@deboer-tim I updated the mockups and the code |
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
997fa16
to
d61300d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. One minor nit but LGTM.
<span class="my-auto font-bold col-span-1 text-right"> | ||
{account.label} | ||
</span> | ||
<Tooltip tip="Sign out of {account.label}" left> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just give the button a title (which is used as a tooltip) instead of using a Tooltip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really have a standard, and have used button/other tooltip for most simple cases and Tooltip for cases where it isn't supported or needs more styling. I'm fine leaving it, let's merge.
What does this PR do?
This PR introduce small change to the Authentification Providers page
Screenshot / video of UI
What issues does this PR fix or reference?
Related to #2274
How to test this PR?
You can use the #5400 to test an authentification provider
CC @mairin :)