Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open openshift routes #5560

Merged
merged 1 commit into from Jan 25, 2024
Merged

feat: open openshift routes #5560

merged 1 commit into from Jan 25, 2024

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

Adds an ability to open provided routes in kubernetes deployments.

Screenshot / video of UI

kubernetesRoutes.mp4

What issues does this PR fix or reference?

#4178

How to test this PR?

Deploy application from sample in OpenShift Console with exposed routes. Go to Podman Desktop. Open Pods page. Navigate to the particular Kubernetes Pod. In the top right corner there is a button appeared with exposed routes.

@vzhukovs vzhukovs requested a review from mairin January 16, 2024 13:27
@vzhukovs vzhukovs self-assigned this Jan 16, 2024
@vzhukovs vzhukovs requested review from benoitf and a team as code owners January 16, 2024 13:27
@vzhukovs vzhukovs requested review from dgolovin and lstocchi and removed request for a team January 16, 2024 13:27
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's missing tests for PodActions changes

@vzhukovs
Copy link
Contributor Author

it's missing tests for PodActions changes

working on them

@slemeur
Copy link
Collaborator

slemeur commented Jan 19, 2024

nice!

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Copy link
Contributor Author

@benoitf, I've added tests

@benoitf
Copy link
Collaborator

benoitf commented Jan 25, 2024

so it's only OpenShift, maybe need to update the title as Routes don't exist on vanilla Kubernetes

People expose ingresses/loadBalancer, etc

@vzhukovs vzhukovs changed the title feat: open kubernetes route feat: open openshift routes Jan 25, 2024
@vzhukovs vzhukovs merged commit 74c8861 into main Jan 25, 2024
8 checks passed
@vzhukovs vzhukovs deleted the pd#4178 branch January 25, 2024 12:35
@podman-desktop-bot podman-desktop-bot added this to the 1.8.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8s pods actions Magical link for viewing apps in browser easily missed (for pods deployed to OpenShift)
4 participants