feat: add webview in the UI #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
cdrage and
feloy
and removed request for
a team
part of containers#5140 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
DESKTOP-5140-c
branch
from
149971f
to
c6136f5
Compare
|
rebased |
|
ok only this one is missing review now |
|
Tested this PR, after rebasing it, works great for me :) |
feloy
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add exposure in the UI for webviews in the navigation bar + exposing the webview
Screenshot / video of UI
Screen.Recording.2024-01-19.at.08.40.29.mov
What issues does this PR fix or reference?
part of #5140
How to test this PR?
unit tests provided