Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose create/start Pod and replicatePodmanContainer #5648

Merged
merged 6 commits into from Jan 23, 2024
Merged

feat: expose create/start Pod and replicatePodmanContainer #5648

merged 6 commits into from Jan 23, 2024

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

It just exposes the createPod, startPod and replicatePodmanContainer functions

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

N/A

@lstocchi lstocchi requested review from benoitf and a team as code owners January 23, 2024 09:15
@lstocchi lstocchi requested review from dgolovin and feloy and removed request for a team January 23, 2024 09:15
@deboer-tim deboer-tim mentioned this pull request Jan 23, 2024
Closed
@lstocchi
feat: expose create/start Pod and replicatePodmanContainer
9bdedb8 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi
fix: fix based on review
8dfb53a 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from benoitf January 23, 2024 14:47
@lstocchi
fix: add provider to podCreateOptions
43441b4 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from benoitf January 23, 2024 16:00
benoitf
benoitf reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getFirstRunningConnection and getFirstRunningPodmanContainerProvider should call them each other and the same for getMatchingEngineFromConnection that should call getMatchingProviderFromConnection
so we don't duplicate lines but calls each other

@lstocchi
fix: make getMatchingEngineFromConnection call getMatchingContainerPr…
af897fe 
…ovider

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi
chore: add comment
eeda544 
Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from benoitf January 23, 2024 17:40
benoitf
benoitf approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@lstocchi
Copy link
Contributor Author

@benoitf thanks to you 👍

@lstocchi lstocchi enabled auto-merge (squash) January 23, 2024 17:44
@lstocchi
fix: adding correct ContainerCreateOptions to api for replicatePodman…
f094bd1 
…Container

Signed-off-by: lstocchi <lstocchi@redhat.com>
@benoitf benoitf enabled auto-merge (rebase) January 23, 2024 18:12
@benoitf benoitf merged commit 1e4d24b into containers:main Jan 23, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.7.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from containers/podman-desktop-reviewers

@feloy feloy Awaiting requested review from feloy feloy is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lstocchi @benoitf @podman-desktop-bot