fix: image usage by containers #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin,
feloy and
cbr7
and removed request for
a team
fixes containers#5583 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
@benoitf I checked the fix on this branch and the original issue is indeed fixed, however I've noticed a somewhat related problem if the user uses the Prune functionality on the duplicate images, while individual copies can now be deleted, the prune bulk action still sees the copies as being in use. I've attached a video of the behavior. Screen.Recording.2024-01-24.at.12.32.11.mov |
|
@cbr7 we delegate the prune operation to the container engine (using the REST API) it won't prune the image as it's used. From the container engine POV, there is only one image with multiple tags. |
cbr7
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Image usage should only match if the image tag is matching as well
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #5583
How to test this PR?
Unit tests
try the case reported by the issue (or another usage)