Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated _Installing Podman Desktop and Podman on Windows_ (compact version) #5751

Merged

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Jan 30, 2024

What does this PR do?

docs: updated Installing Podman Desktop and Podman on Windows (compact version)

Screenshot / video of UI

What issues does this PR fix or reference?

partially fixes #4269

How to test this PR?

@themr0c themr0c requested review from slemeur, benoitf and a team as code owners January 30, 2024 10:44
@themr0c themr0c requested review from cdrage and axel7083 and removed request for a team January 30, 2024 10:44
@themr0c themr0c force-pushed the issue-4269-refactor-windows-install-compact branch from 269f031 to 8ae6399 Compare January 30, 2024 11:27
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments, but it looks like this conflicts / is very similar to #5756 has a lot of copy and paste stuff?

I left reviews in both regardless!

website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
website/docs/installation/windows-install/index.md Outdated Show resolved Hide resolved
@themr0c themr0c requested a review from cdrage February 13, 2024 11:12
@themr0c
Copy link
Contributor Author

themr0c commented Feb 23, 2024

This pull request has received enough comments and is ready to merge. Can you merge it, please?

@themr0c
Copy link
Contributor Author

themr0c commented Mar 4, 2024

The Argos test requires a file that does not exist. I believe the Argos test itself is broken, not this pull request.

@themr0c
Copy link
Contributor Author

themr0c commented Mar 8, 2024

I will continue rebasing and fixing the increasing number of conflicts and errors once I receive an agreement on the content. It makes no sense investing time in this activity if the team has no plan to accept the pull request.

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM having this more on a single page now instead of multiple.

Will need a rebase

themr0c and others added 5 commits March 15, 2024 14:31
…containers#4269

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c themr0c force-pushed the issue-4269-refactor-windows-install-compact branch from 7303ae8 to 546ad41 Compare March 15, 2024 13:31
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c
Copy link
Contributor Author

themr0c commented Mar 15, 2024

Rebased + fixed redirections. Merge at will.

@benoitf
Copy link
Collaborator

benoitf commented Mar 15, 2024

@themr0c it looks like the other PR merged is now conflicting with this one

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@benoitf benoitf enabled auto-merge (squash) March 18, 2024 11:29
@benoitf benoitf merged commit b086ab2 into containers:main Mar 18, 2024
13 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: simplify installation guides
4 participants