Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: updated linux installation docs for 0.8 #578

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

deekay2310
Copy link
Contributor

Signed-off-by: Dev Kumar devskumar99@gmail.com

What does this PR do?

Updated installation documentation for Podman Desktop on Linux

Screenshot/screencast of this PR

Screen Shot 2022-10-11 at 1 27 58 PM

Screen Shot 2022-10-11 at 1 27 53 PM

What issues does this PR fix or reference?

How to test this PR?

Signed-off-by: Dev Kumar <devskumar99@gmail.com>
Copy link
Collaborator

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.
Please keep the structure consistent between all install guides. It should have a "Next Steps" section as on the Mac one.

website/docs/Installation/linux-install.md Show resolved Hide resolved
website/docs/Installation/linux-install.md Outdated Show resolved Hide resolved
website/docs/Installation/linux-install.md Outdated Show resolved Hide resolved
website/docs/Installation/linux-install.md Outdated Show resolved Hide resolved
For example:
> In order to install & start the application, you need to know the Flatpak identifier for the application, that is `io.podman_desktop.PodmanDesktop`.

Run the following command to install the flatpak application,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run the following command to install the flatpak application,
Run the following command to install the Flatpak application,

IMO all references to Flatpak should be capitalized.


Run the following command to install the flatpak application,
### 2. Using [flatpak](https://flatpak.org/setup/) application from [Downloads](/downloads/linux)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 2. Using [flatpak](https://flatpak.org/setup/) application from [Downloads](/downloads/linux)
### 2. Using [flatpak](https://flatpak.org/setup/) on Linux

It's weird that [Downloads] is linked to /downloads/linux in this title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it takes you to the downloads page from where you can obtain the flatpak or the zip file

Signed-off-by: Dev Kumar <devskumar99@gmail.com>
Copy link
Collaborator

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekay2310 deekay2310 enabled auto-merge (rebase) October 17, 2022 13:28
@deekay2310 deekay2310 merged commit 8562a7b into containers:main Oct 17, 2022
@benoitf
Copy link
Collaborator

benoitf commented Oct 17, 2022

@deekay2310 FYI, when merging, you should probably squash the commits (select the other option in the dropdown) if they're about the same subject. We don't need intermediate commits to land into the main branch.

@podman-desktop-bot podman-desktop-bot added this to the 0.9.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants