fix: display back the icons of registries #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of resolving images as files, embed them as resources using vite fixes containers#5742 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
jeffmaury and
feloy
and removed request for
a team
axel7083
approved these changes
Feb 5, 2024
cdrage
approved these changes
Feb 5, 2024
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Feb 5, 2024
* fix: display back the icons of registries instead of resolving images as files, embed them as resources using vite fixes containers#5742 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added a commit
that referenced
this pull request
Feb 6, 2024
* fix: display back the icons of registries instead of resolving images as files, embed them as resources using vite fixes #5742 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
instead of resolving images as files, embed them as resources using vite
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #5742
How to test this PR?
Add unit tests