Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend Podman Desktop API Build Image parameters #5882

Merged
merged 3 commits into from Feb 8, 2024

Conversation

jeffmaury
Copy link
Contributor

Fixes #5851

What does this PR do?

Extend the BuildImageOptions in the Podman Desktop API

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#5851

How to test this PR?

Verify non regression in build image from UI

Fixes containers#5851

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested review from benoitf and a team as code owners February 6, 2024 15:22
@jeffmaury jeffmaury requested review from dgolovin and lstocchi and removed request for a team February 6, 2024 15:22
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf
Copy link
Collaborator

benoitf commented Feb 7, 2024

the build image e2e test is not passing anymore based on CI PR check

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury
Copy link
Contributor Author

the build image e2e test is not passing anymore based on CI PR check

Should be good now

@jeffmaury jeffmaury merged commit d070c53 into containers:main Feb 8, 2024
8 checks passed
@jeffmaury jeffmaury deleted the GH-5851 branch February 8, 2024 07:26
@podman-desktop-bot podman-desktop-bot added this to the 1.8.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Podman Desktop API to allow labels when building images
4 participants