Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance UI styles for summary, details, actions and search bar #589

Merged
merged 5 commits into from
Oct 12, 2022
Merged

feat: enhance UI styles for summary, details, actions and search bar #589

merged 5 commits into from
Oct 12, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 12, 2022

What does this PR do?

  • reduce border width for icons of pods and containers
  • remove indent on title for details
  • add rounded and change background color for the search item
  • do not use small fonts and keep correct spacing for summary
  • reduce icon width in actions in list and reduce space between

Screenshot/screencast of this PR

image
image

What issues does this PR fix or reference?

related to #588

How to test this PR?

Look at the UI

@benoitf
feat: reduce border width for icons of pods and containers
2b920c5 
Change-Id: Icb9fc21ec126342c88586570bbf59e6f29582f2e
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
feat: remove indent on title for details
f6104b1 
Change-Id: Ic01508d1617c43e4dc05548934db1c2905126480
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
feat: add rounded and change background color for the search item
4dae62c 
Change-Id: Ibc6b64a51f724fd3d59ab810b06cce7360238b59
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
feat: do not use small fonts and keep correct spacing for summary inf…
dba4bd1 
…ormation

Change-Id: I0e2b8fa6d0d3fdb1cbd09655e12b44b2270fdba9
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
feat: reduce icon width in actions in list and reduce space between
205b544 
Change-Id: I89cd3ca96804391b2cf75312584ec4c2ff3c1b57
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from slemeur October 12, 2022 14:37
@slemeur
Copy link
Collaborator

slemeur commented Oct 12, 2022

looks good to me 👍

@cdrage
Copy link
Contributor

cdrage commented Oct 12, 2022

Tested and looks good :)

@benoitf benoitf merged commit dbfb8dc into containers:main Oct 12, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.9.0 milestone Oct 12, 2022
@benoitf benoitf deleted the DESKTOP-588a branch October 13, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slemeur slemeur slemeur approved these changes

@cdrage cdrage cdrage approved these changes

@vzhukovs vzhukovs Awaiting requested review from vzhukovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benoitf @slemeur @cdrage @podman-desktop-bot